-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change linters to handle Go 1.22 loopvar change [RM-353] #9580
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9580 +/- ##
==========================================
- Coverage 51.33% 51.31% -0.02%
==========================================
Files 1252 1252
Lines 152048 152028 -20
Branches 3019 3018 -1
==========================================
- Hits 78049 78009 -40
- Misses 73840 73860 +20
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
master/.golangci.yml
Outdated
@@ -211,4 +220,3 @@ linters: | |||
- deadcode # Replaced by unusued. | |||
- maligned # Replaced by govet 'fieldalignment'. | |||
- golint # Replaced by revive. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra change?
d070d61
to
e658170
Compare
Ticket
Description
Go 1.22 had a language change which fixed a common foot gun in Golang. https://go.dev/blog/loopvar-preview
Update our linters to allow you to write code like this
Test Plan
CI passes
Checklist
docs/release-notes/
See Release Note for details.