Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide warning for weak password unless it actually applies [DET-10216] #9538

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Jun 18, 2024

Ticket

DET-10216

Description

Think I accidentally resolved a rebase conflict incorrectly when I merged #9519 . This restores a missing if statement so the toast doesn't just display every single time.

Noticed and fixed during acceptance review with @hkumar92

Test Plan

Same as #9519

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jesse-amano-hpe jesse-amano-hpe requested a review from a team as a code owner June 18, 2024 18:27
@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 06e41f9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6671d18d73fd3c000800883e
😎 Deploy Preview https://deploy-preview-9538--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.26%. Comparing base (3641bfc) to head (06e41f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9538      +/-   ##
==========================================
- Coverage   49.88%   45.26%   -4.62%     
==========================================
  Files        1245      921     -324     
  Lines      161903   121621   -40282     
  Branches     2886     2886              
==========================================
- Hits        80762    55054   -25708     
+ Misses      80970    66396   -14574     
  Partials      171      171              
Flag Coverage Δ
harness ?
web 46.23% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/DeterminedAuth.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesse-amano-hpe jesse-amano-hpe merged commit 8f21555 into main Jun 24, 2024
89 of 102 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/DET-10216/hide-warning-unless-it-applies branch June 24, 2024 16:48
@jesse-amano-hpe jesse-amano-hpe added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jun 24, 2024
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants