Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: devcluster should fail job if step fails [INFENG-640] #9217

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented Apr 22, 2024

Ticket

INFENG-640

Description

I'm trying to solve this problem

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner April 22, 2024 19:10
@JComins000 JComins000 requested a review from dzhu April 22, 2024 19:10
@cla-bot cla-bot bot added the cla-signed label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d47a3a5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6626c5389fb6830008eab972

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.70%. Comparing base (f8b3736) to head (d47a3a5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9217   +/-   ##
=======================================
  Coverage   44.70%   44.70%           
=======================================
  Files        1270     1270           
  Lines      155130   155130           
  Branches     2437     2436    -1     
=======================================
+ Hits        69351    69352    +1     
+ Misses      85543    85542    -1     
  Partials      236      236           
Flag Coverage Δ
backend 41.57% <ø> (+<0.01%) ⬆️
harness 64.31% <ø> (ø)
web 35.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@JComins000 JComins000 merged commit 9590d71 into main Apr 24, 2024
84 of 96 checks passed
@JComins000 JComins000 deleted the jcom/INFENG-640/devcluster-bg-command-should-fail branch April 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants