Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revert helm values change for multirm #9145

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Apr 10, 2024

Ticket

Description

Reverts helm values doc change for multirm.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 329fc7b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6616d5e61bba8e0008ed5c88

@NicholasBlaskey NicholasBlaskey added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.94%. Comparing base (c3d13b6) to head (329fc7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9145      +/-   ##
==========================================
+ Coverage   46.21%   46.94%   +0.72%     
==========================================
  Files        1175      755     -420     
  Lines      145341   104809   -40532     
  Branches     2414     2414              
==========================================
- Hits        67175    49201   -17974     
+ Misses      77957    55399   -22558     
  Partials      209      209              
Flag Coverage Δ
backend 34.24% <ø> (-9.52%) ⬇️
harness 63.99% <ø> (ø)
web 36.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 420 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) April 10, 2024 18:25
@NicholasBlaskey NicholasBlaskey merged commit 4d1b8ae into main Apr 10, 2024
72 of 90 checks passed
@NicholasBlaskey NicholasBlaskey deleted the revert_helm_doc_changes branch April 10, 2024 18:29
dai-release bot pushed a commit that referenced this pull request Apr 10, 2024
carolinaecalderon added a commit that referenced this pull request Apr 17, 2024
carolinaecalderon added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants