ci: publish docs without installing awscli #9126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`publish-docs` ultimately runs `make -C docs publish`, which itself runs the `make publish` in `docs/deploy`. This recipe runs a `terraform init` and a `terraform apply`, neither of which use anything installed with `awscli`.
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9126 +/- ##
==========================================
+ Coverage 46.16% 46.18% +0.02%
==========================================
Files 1174 1174
Lines 145186 145186
Branches 2412 2413 +1
==========================================
+ Hits 67025 67056 +31
+ Misses 77953 77922 -31
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. |
djanicekpach
approved these changes
Apr 9, 2024
wes-turner
added a commit
that referenced
this pull request
Apr 11, 2024
PR #9126 removing the awscli installation was not well tested and doesn't work in production. This adds it back, but explicitly adds it to the user path so that the pip doesn't complain about installation into a system-managed python path.
4 tasks
wes-turner
added a commit
that referenced
this pull request
Apr 11, 2024
PR #9126 removing the awscli installation was not well tested and doesn't work in production. This adds it back, but explicitly adds it to the user path so that the pip doesn't complain about installation into a system-managed python path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish-docsultimately runsmake -C docs publish, which itself runs themake publishindocs/deploy. This recipe runs aterraform initand aterraform apply, neither of which use anything installed withawscli.MD-349
Ticket
Description
Test Plan
I've tested this by hand by SSHing into a CI host, but have not tested it as a part of an automatic pipeline.
Checklist
docs/release-notes/.See Release Note for details.