chore: upgrade Go from 1.21 -> 1.22 #8914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8914 +/- ##
==========================================
- Coverage 47.71% 47.16% -0.55%
==========================================
Files 1066 1154 +88
Lines 170435 175056 +4621
Branches 2237 2237
==========================================
+ Hits 81317 82561 +1244
- Misses 88960 92337 +3377
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
Feb 28, 2024
dannysauer
approved these changes
Feb 28, 2024
NicholasBlaskey
commented
Feb 28, 2024
| @@ -1706,6 +1706,7 @@ jobs: | |||
| root: . | |||
| paths: | |||
| - master/coverage.out | |||
| - master/internal/mocks | |||
There was a problem hiding this comment.
"go test -cover now prints coverage summaries for covered packages that do not have their own test files. Prior to Go 1.22 a go test -cover run for such a package would report"
This change prevents our coverage step to fail since the new Go version requires our mocks be present.
NicholasBlaskey
commented
Feb 28, 2024
| @@ -4,5 +4,5 @@ go install github.com/bufbuild/buf/cmd/[email protected] | |||
| go install golang.org/x/tools/cmd/[email protected] | |||
| go install github.com/goreleaser/[email protected] | |||
| go install github.com/swaggo/swag/cmd/[email protected] | |||
| go install github.com/vektra/mockery/v2@v2.20.0 | |||
| go install github.com/vektra/mockery/v2@v2.42.0 | |||
There was a problem hiding this comment.
mockery had a panic in CI
I never got the mockery error locally though, but upgrading seems to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades Go from 1.21 to 1.22.
Test Plan
CI passes
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket