Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global Config Policies UI [CM-522] #10022

Merged
merged 4 commits into from
Oct 10, 2024

refactor

9d2e3b5
Select commit
Loading
Failed to load commit list.
Merged

feat: Global Config Policies UI [CM-522] #10022

refactor
9d2e3b5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

50.58% (-4.02%) compared to 80b29fa

View this Pull Request on Codecov

50.58% (-4.02%) compared to 80b29fa

Details

Codecov Report

Attention: Patch coverage is 63.40206% with 71 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (80b29fa) to head (9d2e3b5).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/pages/ConfigPoliciesPage.tsx 0.00% 25 Missing and 1 partial ⚠️
webui/react/src/components/ConfigPolicies.tsx 64.06% 23 Missing ⚠️
webui/react/src/components/NavigationSideBar.tsx 0.00% 9 Missing ⚠️
webui/react/src/services/apiConfig.ts 77.50% 9 Missing ⚠️
webui/react/src/routes/index.tsx 0.00% 2 Missing ⚠️
webui/react/src/routes/utils.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10022      +/-   ##
==========================================
- Coverage   54.60%   50.58%   -4.02%     
==========================================
  Files        1259      950     -309     
  Lines      157329   128826   -28503     
  Branches     3621     3636      +15     
==========================================
- Hits        85902    65169   -20733     
+ Misses      71294    63523    -7771     
- Partials      133      134       +1     
Files with missing lines Coverage Δ
webui/react/src/hooks/usePermissions.ts 75.14% <100.00%> (+0.73%) ⬆️
webui/react/src/routes/routes.ts 100.00% <100.00%> (ø)
webui/react/src/services/api.ts 97.86% <100.00%> (+0.03%) ⬆️
webui/react/src/routes/index.tsx 0.00% <0.00%> (ø)
webui/react/src/routes/utils.ts 68.72% <33.33%> (-0.42%) ⬇️
webui/react/src/components/NavigationSideBar.tsx 0.00% <0.00%> (ø)
webui/react/src/services/apiConfig.ts 74.24% <77.50%> (+0.05%) ⬆️
webui/react/src/components/ConfigPolicies.tsx 73.87% <64.06%> (+5.77%) ⬆️
webui/react/src/pages/ConfigPoliciesPage.tsx 0.00% <0.00%> (ø)

... and 310 files with indirect coverage changes