Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuleInstance url #7775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add RuleInstance url #7775

wants to merge 2 commits into from

Conversation

BraisGabin
Copy link
Member

This PR goes in the line to implement #7717 but it's not yet that.

But this simplifies RuleInstance a lot. It had ruleId and ruleName. That was really confusing. With this change we don't need ruleName in the RuleInstance anymore. The only place where we were using the name was to construct the url of each rule. Now, instead of having the ruleName we have the url itself. And now that we have the url itself on the RuleInstance we can implement #7717 and allow each rule to provide it's own url. This way we allow to configure this to custom rules.

Blocked by:

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (f3a6f8f) to head (1bc9a0f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7775      +/-   ##
============================================
- Coverage     85.44%   85.44%   -0.01%     
- Complexity     4183     4184       +1     
============================================
  Files           571      571              
  Lines         13133    13130       -3     
  Branches       2488     2490       +2     
============================================
- Hits          11222    11219       -3     
  Misses          664      664              
  Partials       1247     1247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BraisGabin BraisGabin marked this pull request as ready for review November 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants