-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RuleInstance
url
#7775
Open
BraisGabin
wants to merge
2
commits into
main
Choose a base branch
from
rule-instance-url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add RuleInstance
url
#7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Fixed
Show fixed
Hide fixed
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Fixed
Show fixed
Hide fixed
detekt-report-md/src/main/kotlin/io/github/detekt/report/md/MdOutputReport.kt
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7775 +/- ##
============================================
- Coverage 85.44% 85.44% -0.01%
- Complexity 4183 4184 +1
============================================
Files 571 571
Lines 13133 13130 -3
Branches 2488 2490 +2
============================================
- Hits 11222 11219 -3
Misses 664 664
Partials 1247 1247 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
rule-instance-url
branch
from
November 9, 2024 17:23
f65f1bc
to
ddfd47a
Compare
BraisGabin
force-pushed
the
rule-instance-url
branch
from
November 13, 2024 07:34
ddfd47a
to
220e234
Compare
BraisGabin
force-pushed
the
rule-instance-url
branch
from
November 13, 2024 07:41
220e234
to
1bc9a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes in the line to implement #7717 but it's not yet that.
But this simplifies
RuleInstance
a lot. It hadruleId
andruleName
. That was really confusing. With this change we don't needruleName
in theRuleInstance
anymore. The only place where we were using thename
was to construct theurl
of each rule. Now, instead of having theruleName
we have theurl
itself. And now that we have theurl
itself on theRuleInstance
we can implement #7717 and allow each rule to provide it's ownurl
. This way we allow to configure this to custom rules.Blocked by: