Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v2.3.0-testnet #672

Merged
merged 4 commits into from
Nov 3, 2021
Merged

chore: release v2.3.0-testnet #672

merged 4 commits into from
Nov 3, 2021

Conversation

RiccardoM
Copy link
Contributor

Description

This PR prepares the release for the v2.3.0-testnet version of Desmos, which fixes how the application link verification flow is handled in order to avoid any error due to parallel verification requests or deleted links.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
Signed-off-by: Riccardo Montagnin <[email protected]>
@github-actions github-actions bot added the kind/ci Improve the CI/CD label Nov 3, 2021
@RiccardoM RiccardoM added automerge Automatically merge PR once all prerequisites pass requires-upgrade Test the on-chain upgrade for this PR labels Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #672 (b7f05dd) into master (9da9567) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   15.78%   15.78%           
=======================================
  Files         169      169           
  Lines       46009    46009           
=======================================
  Hits         7263     7263           
  Misses      38119    38119           
  Partials      627      627           
Impacted Files Coverage Δ
app/app.go 82.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9da9567...b7f05dd. Read the comment docs.

Copy link
Contributor

@dadamu dadamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

Copy link
Contributor

@leobragaz leobragaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ready to go

@mergify mergify bot merged commit 581744d into master Nov 3, 2021
@mergify mergify bot deleted the release/v2.3.0-testnet branch November 3, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/ci Improve the CI/CD requires-upgrade Test the on-chain upgrade for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants