fix!: fix third party proto files #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 218 218
Lines 18289 18289
=======================================
Hits 14722 14722
Misses 2955 2955
Partials 612 612 ☔ View full report in Codecov by Sentry. |
dadamu
commented
Aug 15, 2023
| @@ -3,7 +3,7 @@ | |||
| set -eo pipefail | |||
|
|
|||
| cd proto | |||
| proto_dirs=$(find ./desmos -path -prune -o -name '*.proto' -print0 | xargs -0 -n1 dirname | sort | uniq) | |||
| proto_dirs=$(find . -path -prune -o -name '*.proto' -print0 | xargs -0 -n1 dirname | sort | uniq) | |||
There was a problem hiding this comment.
Replace to . in order to make sure oracle and ethermint protos be generated.
dadamu
changed the title
dadamu
commented
Aug 15, 2023
| CRYPTO_TYPES = types/crypto | ||
|
|
||
| update-deps-types: | ||
| @mkdir -p $(CRYPTO_TYPES)/ethsecp256k1 | ||
| @curl -sSL $(EVMOS_URL)/ethsecp256k1/keys.pb.go > $(CRYPTO_TYPES)/ethsecp256k1/keys.pb.go | ||
| @curl -sSL $(EVMOS_URL)/ethsecp256k1/ethsecp256k1.go > $(CRYPTO_TYPES)/ethsecp256k1/ethsecp256k1.go | ||
| @curl -sSL $(EVMOS_URL)/proto/ethermint/crypto/v1/ethsecp256k1/keys.proto > proto/ethermint/crypto/v1/ethsecp256k1/keys.proto |
There was a problem hiding this comment.
Instead of copy pb.go file directly, it is better to download proto file then generate the pb.go file with the specified proto builder which cosmos sdk applies, in order to avoid from the marshaling/unmarshaling issue.
RiccardoM
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the oracle proto files to be generated by proto builder applied by cosmos v0.47.x, in order to make sure packet unmarshaling work properly when receiving IBC packets from Band Protocol.
It also updates the third party ethscep256k1 proto to prevent from the potential issue about marshaling/unmarshaling.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change