Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link color inside dark theme accordion fails WCAG 2.1, SC 1.4.3 requirements #14

Open
3 tasks done
aorlova2909 opened this issue Nov 2, 2021 · 1 comment
Open
3 tasks done

Comments

@aorlova2909
Copy link

Bug report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

In 'Overview' tab, in dark mode example, the link 'is' inside the accordion is blue #0000EE on blue background #135E70 which gives color contrast ratio of 1.28:1.

What I expected to happen

The contrast ratio of the text against the background should be at least 4.50:1 for small text and 3.00:1 for large text (14pt bold or 18 pt+).
See correct implementation in 'Accessibility' tab, 'Keyboard accessibility' example.

Reproducing

Steps to reproduce:

  1. Open https://gold.designsystemau.org/components/accordion/
  2. In 'Overview' tab expand the dark theme accordions
  3. Measure the color contrast ratio of blue 'is' link on blue background

Attachments

goldDS-accordion-blue link on blue

@dominikwilkowski
Copy link
Member

This is actually like this on purpose as text content inside the accordion should be wrapped in body which would fix this issue. But I do see this as not a great experience in the docs so maybe we should have the docs use the body component as well to make that clear? It might just be confusion about since it is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants