Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow token examples dimension format #256

Conversation

mark-tomlinson-dev
Copy link
Contributor

Fix Shadow Token Examples to Match Specification

Updated both the layered-shadow and inner-shadow examples to use the correct dimension object format:

  • e.g. "24px"{ "value": 24, "unit": "px" }

This ensures the examples are consistent with the dimension value specification as outlined in section 8.2.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for dtcg-tr ready!

Name Link
🔨 Latest commit 90f8c99
🔍 Latest deploy log https://app.netlify.com/sites/dtcg-tr/deploys/671f1d18d09a600007641a1a
😎 Deploy Preview https://deploy-preview-256--dtcg-tr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you! I think this accidentally got skipped because both proposals were open for feedback at once, and didn’t get rebased properly.

@drwpow drwpow merged commit 8109290 into design-tokens:main Oct 29, 2024
6 checks passed
github-actions bot added a commit that referenced this pull request Oct 29, 2024
SHA: 8109290
Reason: push, by drwpow

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants