Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1.4 of get-size breaks AMD / bower installation of Draggabilly #32

Closed
heimojuh opened this issue Aug 8, 2013 · 2 comments
Closed

Comments

@heimojuh
Copy link

heimojuh commented Aug 8, 2013

Hi!

Just for information, not sure if you'd want to bind Draggabilly to version 1.1.3 of get-size, since this change pretty much crashes AMD config with require.js, at least in setup where using simple component lib for bower stuff (I define, as I suspect others who use bower/amd/require, Draggability deps on boot.js or similar and get-style-property/get-style-property botches loading as Draggabilly wants just 'get-style-property' AMD dependency on 1.0.4.

  define( [ 'get-style-property/get-style-property' ], defineGetSize );

line 176 on get-size.js.

It's a nasty jungle with module loading :(

@heimojuh
Copy link
Author

heimojuh commented Aug 8, 2013

This of course can be fixed by doing something like

bower install --save get-size#1.1.3

on project using Draggabilly.

@desandro
Copy link
Owner

desandro commented Aug 8, 2013

Thanks for the heads up! I updated bower.json to fix this bad require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants