Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: WebRTC component not found (Android Companion app) #240

Closed
conorlap opened this issue Dec 14, 2021 · 7 comments · Fixed by #296
Closed

Bug: WebRTC component not found (Android Companion app) #240

conorlap opened this issue Dec 14, 2021 · 7 comments · Fixed by #296
Labels
bug Something isn't working

Comments

@conorlap
Copy link

Checklist:

  • [ yes ] I updated to the latest version available
  • [ yes ] I cleared the cache of my browser

Release with the issue:
HA: 2021.12.1
frigate-hass-card: v2.1.0
AlexxIT/WebRTC card: v2.2.0

Last working release (if known):
Not known

Browser and Operating System:
Android companion app - beta-1776-8c5149dd-full (issue is also happening on latest Play Store version)

Description of problem:

Occasionally when I open the HA companion app I get the below error, this issue doesn't occur when I use the regular WebRTC camera card on it's own (https://github.com/AlexxIT/WebRTC). Please note it's only an occasional error and only happens sporadically (approx 1 or 2 times out of 10).
The card loads fine if I close the app and open it again, or tap the clips/recordings button and then go back to live view.

Screenshot 2021-12-14 at 13 36 54

Javascript errors shown in the web inspector (if applicable):

N/A

Additional information:

N/A

@conorlap conorlap added the bug Something isn't working label Dec 14, 2021
@dermotduffy
Copy link
Owner

Thanks for the report @conorlap ! I have not seen this before. Perhaps some sort of race condition between the Frigate card loading and the resources for the rest of the page loading. If the Frigate card loaded before WebRTC, it wouldn't be able to find the webrtc-camera element and you'd probably get that error.

@cappiel
Copy link

cappiel commented Dec 15, 2021

I've been also getting this error since upgrading to the following, I've also uninstalled and reinstalled the card. Dermotduffy did you solve?

HA: 2021.12.1
frigate-hass-card: v2.1.0
AlexxIT/WebRTC card: v2.2.0

@dermotduffy
Copy link
Owner

dermotduffy commented Dec 15, 2021

@cappiel didn't even get a chance to investigate yet ;-)

When you say "since upgrading", do you mean it used to not be a problem -- then you upgraded the card -- then it was a problem? Is this the Frigate card, of the WebRTC card? Do you know what version(s) you were on before?

@cappiel
Copy link

cappiel commented Dec 15, 2021

@dermotduffy all good! sorry that came across bad haha

Yea, so I upgraded HA to 2021.12.1 on Sunday. That broke WebRTC I know. AlexxIT fixed that with 2.2. and installed that earlier today.

I'm pretty sure I upgraded your card on Sunday also to 2.1 through HACS. Seeing similar issue as Conor above. (Not Android though, web and/or iOS HA app)

Any logs I can pull for ya?

@dermotduffy
Copy link
Owner

Thanks @cappiel , no worries! So sounds like you did a big upgrade of HA, WebRTC and the Frigate card -- so can't really pin it down :-(

@conorlap was this triggered by a recent upgrade for you also, or "always" been this way?

@conorlap
Copy link
Author

@dermotduffy I've only setup Frigate and this card within the past week so not sure how long this issue has been present.

@dermotduffy
Copy link
Owner

With a caution that I could never reproduce this bug on any device (and so cannot test it has fixed the issue), I think the merged PR fixes at least one race condition I could imagine during loading that may cause the described behavior. If someone has this issue reliably, would love your feedback after the next release to determine if it's really fixed correctly.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants