Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu items at the top of the screen are darker than specified #1875

Open
davesykeselateral opened this issue Nov 25, 2022 · 2 comments · May be fixed by #2965
Open

Menu items at the top of the screen are darker than specified #1875

davesykeselateral opened this issue Nov 25, 2022 · 2 comments · May be fixed by #2965

Comments

@davesykeselateral
Copy link

davesykeselateral commented Nov 25, 2022 •
edited
Loading




Describe the bug
Menu items appear to use a very dark version of the specified colour

To Reproduce
Steps to reproduce the behavior:

  1. Use default skin, which specifies frame.menu.fgColor to be white
    image
  2. Look at the menu - the menu text is dark gray
    image
  3. Just to confirm that the right field is being edited, change frame.menu.fgColor to be blue
    image
  4. check, now it is shown in dark blue
    image

Expected behavior
I believe the specified colours should be used

Screenshots
Added in line above

Versions (please complete the following information):

  • OS: MacOS Ventura 13.0.1 (22A400)
  • K9s: 0.26.7
  • K8s: 1.24.6

Additional context
It's obviously not a huge problem, but my old eyes struggle with the lack of contrast here.
@pckbls
Copy link

pckbls commented Nov 29, 2022

It's not only the foreground color. Depending on the chosen terminal emulator the background color is also off. Here's an example of what the affected UI section looks like in VSCode's embedded terminal on Mac OS X.

Screenshot 2022-11-29 at 11 27 48

@albertgustavsson
Copy link

It looks like the foreground is hard-coded to be dim. Not sure if that could also be causing the background color behavior observed by @pckbls

@albertgustavsson albertgustavsson linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make menu foreground style configurable through skins albertgustavsson/k9s
3 participants
@davesykeselateral @pckbls @albertgustavsson