From aec4e70be6483e7ced1084172546148127d903e6 Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Thu, 16 May 2019 08:17:59 -0600 Subject: [PATCH 1/2] test: fix flakey test --- test/core/reporters/raw-env.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/core/reporters/raw-env.js b/test/core/reporters/raw-env.js index cd25550046..d37835587b 100644 --- a/test/core/reporters/raw-env.js +++ b/test/core/reporters/raw-env.js @@ -135,6 +135,13 @@ describe('reporters - raw-env', function() { } var env = helpers.getEnvironmentData(); assert.deepEqual(results.raw, rawResults); + assert.isDefined(results.env); + assert.isDefined(results.env.timestamp); + + // remove datetime strings as they can be off by ms which fail + // equality tests + results.env.timestamp = ''; + env.timestamp = ''; assert.deepEqual(results.env, env); done(); }); From defb36b1a8d2be11fa61ff7c66726d2c5295a789 Mon Sep 17 00:00:00 2001 From: Steven Lambert Date: Thu, 16 May 2019 08:24:28 -0600 Subject: [PATCH 2/2] copy test from v1 reporter --- test/core/reporters/raw-env.js | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/test/core/reporters/raw-env.js b/test/core/reporters/raw-env.js index d37835587b..47a761ac10 100644 --- a/test/core/reporters/raw-env.js +++ b/test/core/reporters/raw-env.js @@ -1,4 +1,3 @@ -/*global helpers */ describe('reporters - raw-env', function() { 'use strict'; @@ -133,16 +132,12 @@ describe('reporters - raw-env', function() { if (err) { return done(err); } - var env = helpers.getEnvironmentData(); assert.deepEqual(results.raw, rawResults); - assert.isDefined(results.env); - assert.isDefined(results.env.timestamp); - - // remove datetime strings as they can be off by ms which fail - // equality tests - results.env.timestamp = ''; - env.timestamp = ''; - assert.deepEqual(results.env, env); + assert.isNotNull(results.env); + assert.isNotNull(results.env.url); + assert.isNotNull(results.env.timestamp); + assert.isNotNull(results.env.testEnvironement); + assert.isNotNull(results.env.testRunner); done(); }); });