Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip links and landmark regions #863

Closed
digitala11y opened this issue Apr 26, 2018 · 2 comments · Fixed by #1496
Closed

Skip links and landmark regions #863

digitala11y opened this issue Apr 26, 2018 · 2 comments · Fixed by #1496
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@digitala11y
Copy link

Ensures all content is contained within a landmark region

URL:https://www.digitala11y.com

Lang attribute cannot be wrapped inside a landmark region.

@marcysutton
Copy link
Contributor

Have a look at the related nodes. Those are the elements that aXe is saying should be wrapped in a landmark region. In this case they're skip links, which we've talked about making exempt.

@WilcoFiers
Copy link
Contributor

Our skiplink ignore part of this rule should account for multiple skip links in a page. I think that's the fix here.

@WilcoFiers WilcoFiers added the fix Bug fixes label Apr 26, 2018
@marcysutton marcysutton changed the title Landmark for lang attribute bug Skip links and landmark regions May 3, 2018
@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Oct 18, 2018
@WilcoFiers WilcoFiers added this to the Axe-core 3.3 milestone May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants