feat(aria): Support progressive ARIA 1.1 attributes / roles #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for role=feed, role=term, aria-placeholder, aria-modal, aria-current, aria-keyshortcuts
|
How's the support for all of these new things? |
|
@marcysutton as far as I know none of them are supported currently. The reason we're adding them is because it's better to use them now, even if they aren't supported, since they will presumably be implemented at some point. Also, unlike some of the other features new to ARIA 1.1, these features aren't likely to cause accessibility problems if they're not supported. They simply add to the user experience when support is there. |
|
They're also used in some of the ARIA authoring practices guide. It's somewhat confusing to be following guidelines for (in my case Modals) and seeing my specs fail because I'm using a new attribute. |
dylanb
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for role=feed, role=term, aria-placeholder, aria-modal,
aria-current and aria-keyshortcuts.
This PR closes #350.