Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more ARIA attributes that are string values to be empty #4108

Closed
WilcoFiers opened this issue Jul 28, 2023 · 1 comment · Fixed by #4109
Closed

Allow more ARIA attributes that are string values to be empty #4108

WilcoFiers opened this issue Jul 28, 2023 · 1 comment · Fixed by #4109
Assignees
Labels
fix Bug fixes standards Issues in the ARIA standards objects (lib/standards)
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jul 28, 2023

There are a few newer ARIA attributes of type: string that I think should be allowed as empty:

  • aria-braillelabel
  • aria-brailleroledescription
  • aria-valuetext

Since both aria-label and aria-roledescription are allowed to be empty, I see no reason why their braille equivalents shouldn't be. As for valuetext, it seems fairly reasonable that values can be empty, so aria-valuetext should be allowed empty too.

@WilcoFiers WilcoFiers added fix Bug fixes standards Issues in the ARIA standards objects (lib/standards) labels Jul 28, 2023
@WilcoFiers WilcoFiers added this to the Axe-core 4.8 milestone Jul 28, 2023
@WilcoFiers WilcoFiers self-assigned this Jul 28, 2023
@padmavemulapati
Copy link

validated using latest axe-core develop branch code base,
braille equivalent rule also allowing
aria-braillelabel
aria-brailleroledescription
aria-valuetext allowing empty

Image

Recording tells us allowed and fail conditions of the checks:

Screen.Recording.2023-08-03.at.2.49.14.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes standards Issues in the ARIA standards objects (lib/standards)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants