Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put aria-conditional-attr (from aria-allowed-attr) into its own rule #4068

Closed
Tracked by #4066
WilcoFiers opened this issue Jun 28, 2023 · 1 comment · Fixed by #4094
Closed
Tracked by #4066

Put aria-conditional-attr (from aria-allowed-attr) into its own rule #4068

WilcoFiers opened this issue Jun 28, 2023 · 1 comment · Fixed by #4094
Assignees
@WilcoFiers
Labels
feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Milestone
Axe-core 4.8

Comments

@WilcoFiers
Copy link
Contributor

Part of #4066

The aria-conditional-attr check should run in its own rule, instead of as part of aria-allowed-attr.
@WilcoFiers WilcoFiers added feat New feature or enhancement rules Issue or false result from an axe-core rule rule metadata Issues in the rule metadata code (lib/rules) labels Jun 28, 2023
@WilcoFiers WilcoFiers mentioned this issue Jun 28, 2023
Closed
5 tasks
@WilcoFiers WilcoFiers added this to the Axe-core 4.8 milestone Jun 28, 2023
@WilcoFiers WilcoFiers self-assigned this Jul 17, 2023
@WilcoFiers WilcoFiers mentioned this issue Jul 18, 2023
Merged
@straker straker added the pr A pr has been created for the issue label Jul 24, 2023
@padmavemulapati
Copy link

Valdiated using latest axe-core develop branch code base,

now seeing aria-conditional-attr as a seperate rule not as part of aria-allowed-attr when the attributes are at certain conditions

Image

Earlier those are under aria-allowed-attr

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules) rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
Axe-core 4.8
Development

Successfully merging a pull request may close this issue.

feat: add rule aria-conditional-attr dequelabs/axe-core
3 participants
@WilcoFiers @straker @padmavemulapati