Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video-caption rule should not have excludeHidden: false #3488

Closed
WilcoFiers opened this issue Jun 1, 2022 · 1 comment
Closed

video-caption rule should not have excludeHidden: false #3488

WilcoFiers opened this issue Jun 1, 2022 · 1 comment
Assignees
Labels
ACT Rules good first issue For first-time contributors pr A pr has been created for the issue
Milestone

Comments

@WilcoFiers
Copy link
Contributor

These two rules should ignore hidden elements. The following should not be flagged as incomplete:

https://act-rules.github.io/rules/eac66b#inapplicable-example-1

<video src="/test-assets/perspective-video/perspective-video.mp4" controls style="display: none;"></video>

The only thing to do on this is update lib/rules/video-caption.json and remove excludeHidden, and possibly tweak the integration tests for it.

@WilcoFiers WilcoFiers added ACT Rules good first issue For first-time contributors labels Jun 1, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone Jun 1, 2022
@straker straker added the pr A pr has been created for the issue label Jul 21, 2022
@padmavemulapati
Copy link

Validated with the latest develop branch code base, when controls style="dispaly: none;" , vidoe-caption is rule is going to inapplicable
Script: <video src="/Users/dq_user/downloads/video.mp4" controls style="display: none;"></video>

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules good first issue For first-time contributors pr A pr has been created for the issue
Projects
None yet
Development

No branches or pull requests

4 participants