Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have meta-viewport map to SC 1.4.4 again #3460

Closed
WilcoFiers opened this issue May 18, 2022 · 3 comments
Closed

Have meta-viewport map to SC 1.4.4 again #3460

WilcoFiers opened this issue May 18, 2022 · 3 comments
Assignees
Labels
ACT Rules feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)
Milestone

Comments

@WilcoFiers
Copy link
Contributor

The meta-viewport rule used to map to SC 1.4.4, but is now considered a best practice. We changed this in axe-core v3.5. However in the meta viewport allows for zoom ACT rule, this is still considered a failure of SC 1.4.4. I think there's still a reasonable argument for doing so. Lots of people do not have the latest Iphone or Android device. Plus the default setting of Chrome and Firefox do prevent zoom. You can change it, but in the spirit of "without assistive technology", I'm not sure an "prevented by default" is actually sufficient.

Here's a recent write-up on the topic that was making the rounds: https://www.matuzo.at/blog/2022/please-stop-disabling-zoom/

@WilcoFiers WilcoFiers added feat New feature or enhancement rule metadata Issues in the rule metadata code (lib/rules) ACT Rules labels May 18, 2022
@WilcoFiers WilcoFiers added this to the Axe-core 4.5 milestone May 18, 2022
@WilcoFiers
Copy link
Contributor Author

WilcoFiers commented May 23, 2022

This rule was approved by the ACT Task Force, and is scheduled for review by AGWG hopefully somewhere in September. If AGWG approves the rule for 1.4.4, we'll make the change in axe-core. We'll want to wait for that decision before making the change.

@WilcoFiers WilcoFiers self-assigned this Sep 23, 2022
@WilcoFiers WilcoFiers added pr A pr has been created for the issue and removed pr A pr has been created for the issue labels Sep 27, 2022
@WilcoFiers
Copy link
Contributor Author

AGWG approved this change. We're updating axe-core.

@WilcoFiers WilcoFiers added the pr A pr has been created for the issue label Oct 8, 2022
@padmavemulapati
Copy link

Validated with the latest axe-core develop branch code base,
meta-viewport is failing in SC1.4.4 but not showing as best-practice for the test script:

<meta
  name="viewport"
  id="mvp"
  content="User-Scalable= no;
										 maximum-scale=2;"
/>
Footer

but for this test script it also fail for meta-viewport-large rule, which is having best-practice tag

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules feat New feature or enhancement pr A pr has been created for the issue rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

No branches or pull requests

2 participants