feat(utils): add getFrameContexts method #2995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Jun 16, 2021
WilcoFiers
commented
Jun 16, 2021
| import getAncestry from './get-ancestry' | ||
|
|
||
| export default function getFrameContexts(context) { | ||
| const { frames } = new Context(context); |
There was a problem hiding this comment.
This creates axe._tree, which is going to slow stuff down. Can we avoid that? And if not, how do we avoid either a tree that is outdated by the time axe.runPartial is called, or generating the tree twice.
There was a problem hiding this comment.
Do we want to fix this in this pr or another one?
There was a problem hiding this comment.
Nope, we can let Context build axe._tree. I've accounted for it in the updated proposal.
WilcoFiers
commented
Jun 23, 2021
| import getAncestry from './get-ancestry' | ||
|
|
||
| export default function getFrameContexts(context) { | ||
| const { frames } = new Context(context); |
There was a problem hiding this comment.
Nope, we can let Context build axe._tree. I've accounted for it in the updated proposal.
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
michael-siek
approved these changes
Jun 24, 2021
|
For the record: I passed this one off to Steve, who finished it up. Steve checked my work, and I checked his additions. Michael reviewed this for security. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a utility which is passed a context object, and returns the context for each iframe.
Closes issue: #2937