Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link-name should allow titles #2459

Closed
WilcoFiers opened this issue Aug 16, 2020 · 3 comments
Closed

Link-name should allow titles #2459

WilcoFiers opened this issue Aug 16, 2020 · 3 comments
Assignees
Labels
ACT Rules fix Bug fixes good first issue For first-time contributors rules Issue or false result from an axe-core rule
Milestone

Comments

@WilcoFiers
Copy link
Contributor

In axe-core 4.0 we changed how has-visible-text behaves. It now only looks at content, not at accessible name props for things. Because of that, the following code snippet now fails the link-name rule:

<a href="http://www.w3.org/WAI" title="Web Accessibility Initiative">
	<img src="/test-assets/shared/w3c-logo.png" alt="" />
</a>

The reason for this is that the non-empty-title check is not used in the link-name rule (as as it is for things like button-name). I vaguely remember we did that because we didn't want to encourage the use of the title attribute. I think support has improved since that time, so I think it's save to add it.

@DaveTryon
Copy link
Contributor

@WilcoFiers, any thoughts on when a release might be published with this? We're working towards using axe-core 4.0.1 in Accessibility Insights and are trying to determine our best options. Thanks!

@padmavemulapati
Copy link

Link-name rule should pass if title present fail otherwise
image

@straker
Copy link
Contributor

straker commented Sep 24, 2020

No docs required

@straker straker closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules fix Bug fixes good first issue For first-time contributors rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

4 participants