feat(label,select-name): allow placeholder to pass label rule, add select-name rule #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Aug 14, 2020
| "impact": "serious", | ||
| "messages": { | ||
| "pass": "Element has a placeholder attribute", | ||
| "fail": "Element has no placeholder attribute or the placeholder attribute is empty" |
There was a problem hiding this comment.
Lets distinguish between these two. I realise this is also true for non-empty-title, I'll open a tech debt ticket for that.
There was a problem hiding this comment.
Doing this would make the generic check attr-non-space-content change, which in turn affects the 3 other checks that rely on it: none-empty-alt, none-empty-value, non-empty-title (the tests and messages would need to be updated in each of those to handle this.data being called in the check).
As such, this change would be outside the scope of the PR and I vote we do this in a separate PR (the ticket you created).
WilcoFiers
previously requested changes
Aug 16, 2020
WilcoFiers
approved these changes
Aug 20, 2020
ahuth
added a commit
to chanzuckerberg/axe-storybook-testing
that referenced
this pull request
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label rule also applied to
selectelements which can't have placeholder attribute, so had to split the rule up.The placeholder name calculation is part of step 2D, native text methods, so that's where I put it.
Also, we had tests in the accessible-name calculation code for placeholder that were skipped, so I could just unskip them.
Closes issue: #2413
Reviewer checks
Required fields, to be filled out by PR reviewer(s)