Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule th-has-data-cells does not return expected result #2013

Closed
jeeyyy opened this issue Feb 4, 2020 · 3 comments
Closed

Rule th-has-data-cells does not return expected result #2013

jeeyyy opened this issue Feb 4, 2020 · 3 comments
Assignees
Labels
ACT Rules fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Feb 4, 2020

Expectation: The example below should fail.

<table>
	<tr>
		<th id="col1">Column 1</th>
		<th id="Column2">Column 2</th>
	</tr>
	<tr>
		<td></td>
		<td headers="col1"></td>
	</tr>
</table>

Actual:
Does not fail.

Motivation:


axe-core version: X.Y.Z
axe-webdriver, extension or other integration version: X.Y.Z

Browser and Assistive Technology versions

For Tooling issues:
- Node version: XX  
- Platform:  
@straker
Copy link
Contributor

straker commented Feb 4, 2020

The check only looks at if the row/column has a cell that is not a header but fails to look if the cell points at a different header than the current row/column

@straker straker added fix Bug fixes rules Issue or false result from an axe-core rule labels Feb 7, 2020
@jeeyyy jeeyyy self-assigned this Feb 11, 2020
@straker straker self-assigned this Mar 11, 2020
@jeeyyy jeeyyy changed the title Rule th-has-data-cells does not return expected result [QA] Rule th-has-data-cells does not return expected result Mar 16, 2020
@padmavemulapati
Copy link

Verified with the latest axe-core, as per the fix, it was motivated to fail for the table headers, but it never fails. We are seeing now it is into incomplete instead pass

image (11)

@jeeyyy jeeyyy changed the title [QA] Rule th-has-data-cells does not return expected result Rule th-has-data-cells does not return expected result Mar 24, 2020
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Mar 24, 2020

No docs change. Closing issue.

@jeeyyy jeeyyy closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT Rules fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

3 participants