test(examples): do not fail tests if deque.com has violations #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the `phantomjs` example test, making it not fail if an axe-core violation is found on deque.com. While it's extremely embarrassing that deque.com has violations, it's not something we control, so we shouldn't block merges based on it.
straker
approved these changes
Jul 8, 2019
|
@straker can you please fill in the checklist? |
|
Sorry, done |
WilcoFiers
pushed a commit
that referenced
this pull request
Jul 22, 2019
This patch updates the `phantomjs` example test, making it not fail if an axe-core violation is found on deque.com. While it's extremely embarrassing that deque.com has violations, it's not something we control, so we shouldn't block merges based on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
phantomjsexample test, making it not fail if an axe-core violation is found on deque.com.While it's extremely embarrassing that deque.com has violations, it's not something we control, so we shouldn't block merges based on it.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)