Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: Color-contrast rule fails when partially opaque overlay div is placed on top of content #1459

Closed
iamrafan opened this issue Mar 26, 2019 · 14 comments
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support

Comments

@iamrafan
Copy link
Contributor

iamrafan commented Mar 26, 2019

Expectation: Not fail the color-contrast rule when partially opaque overlay div is placed on top of a section of view port

Actual: Fails color-contrast rule

Motivation: Once the side panel opens, the blurred out content need not be accessible to the user.

Demo link: https://developer.microsoft.com/en-us/fabric#/components/panel

image

image

axe-core version: 3.1.2
axe-Coconut version: 3.7.0
@WilcoFiers
Copy link
Contributor

Interesting. I reran this page with 3.2.2, 3.1.2 and 3.0.3, none of them report it. Is it possible this page has changed since?

@WilcoFiers WilcoFiers added needs discussion More discussion is needed to continue support labels Mar 26, 2019
@iamrafan
Copy link
Contributor Author

@WilcoFiers No, I can still repro the issue using axe-core 3.1.2.

@aellsey aellsey added this to the HTMLTools Sprint 2 milestone Apr 21, 2019
@WilcoFiers WilcoFiers modified the milestones: HTMLTools Sprint 2, Axe-core 3.3 Apr 23, 2019
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule and removed needs discussion More discussion is needed to continue labels Apr 23, 2019
@roman-bytes roman-bytes self-assigned this Apr 26, 2019
@roman-bytes
Copy link
Contributor

@iamrafan Can you shed a little light on how this page is handling trapping the focus within the pop out panel? This will help with debugging. Thanks!

@iamrafan
Copy link
Contributor Author

iamrafan commented May 2, 2019

@Roman-II I am not on the same team, I am not sure how the focus is being handled here

@cnamal
Copy link

cnamal commented May 4, 2019

Pinged folks from OUFR to provide assistance.

@dzearing
Copy link

dzearing commented May 7, 2019

@kkjeer can you help take a look?

@kkjeer
Copy link

kkjeer commented May 7, 2019

Panel uses a FocusTrapZone for focus management. @JasonGore is more familiar with the FocusTrapZone component.

@JasonGore
Copy link

This issue is reporting a contrast issue with Overlay. I'm not sure what to do here from a FocusTrapZone perspective. FocusTrapZone does not apply any styling. If there is a FocusTrapZone focus issue to look into, I'd recommend creating a new issue.

@jeankaplansky
Copy link
Contributor

No docs required.

@chandana7393
Copy link

Tested, still reproducible.
overlap_needs_review
Tested Environment:
Axe-coconut - 3.8.1.19604v
Chrome -75v
OS - Windows 10 64 bit.

@roman-bytes
Copy link
Contributor

@chandana7393 That screenshot is expected behavior. We still raise an issue, just under needs review and "Element is overlapped by another element." Also took a peek at this myself and the current element being looked at is actually behind the panel on the right side.

@chandana7393
Copy link

@Roman-II This behaviour is observed in the previous axe-core version, then what are the changes in this rule and what is the expected output of this ticket would you please let me know.

@roman-bytes
Copy link
Contributor

@chandana7393 The main change is moving those color-contrast violations to needs review. The screenshot you provided is the expected output, as the element is behind the panel.

@chandana7393
Copy link

Thank you @Roman-II
Tested, Working as expected.
under_needs_review
Tested Environment:
Axe-coconut - 3.8.1.19721v
Chrome - 75.0.3770.142v
OS - Windows 10 64 bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support
Projects
None yet
Development

No branches or pull requests

10 participants