-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive: Color-contrast rule fails when partially opaque overlay div is placed on top of content #1459
Comments
Interesting. I reran this page with 3.2.2, 3.1.2 and 3.0.3, none of them report it. Is it possible this page has changed since? |
@WilcoFiers No, I can still repro the issue using axe-core 3.1.2. |
@iamrafan Can you shed a little light on how this page is handling trapping the focus within the pop out panel? This will help with debugging. Thanks! |
@Roman-II I am not on the same team, I am not sure how the focus is being handled here |
Pinged folks from OUFR to provide assistance. |
@kkjeer can you help take a look? |
Panel uses a FocusTrapZone for focus management. @JasonGore is more familiar with the FocusTrapZone component. |
This issue is reporting a contrast issue with Overlay. I'm not sure what to do here from a FocusTrapZone perspective. FocusTrapZone does not apply any styling. If there is a FocusTrapZone focus issue to look into, I'd recommend creating a new issue. |
No docs required. |
@chandana7393 That screenshot is expected behavior. We still raise an issue, just under needs review and "Element is overlapped by another element." Also took a peek at this myself and the current element being looked at is actually behind the panel on the right side. |
@Roman-II This behaviour is observed in the previous axe-core version, then what are the changes in this rule and what is the expected output of this ticket would you please let me know. |
@chandana7393 The main change is moving those color-contrast violations to needs review. The screenshot you provided is the expected output, as the element is behind the panel. |
Thank you @Roman-II |
Expectation: Not fail the color-contrast rule when partially opaque overlay div is placed on top of a section of view port
Actual: Fails color-contrast rule
Motivation: Once the side panel opens, the blurred out content need not be accessible to the user.
Demo link: https://developer.microsoft.com/en-us/fabric#/components/panel
The text was updated successfully, but these errors were encountered: