Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule): Prevent th-has-data-cells from crashing on empty rows #1285

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Dec 19, 2018

Since rows can be empty (<tr> </tr>) getScope shouldn't assume there are cells in every row.

Closes #1266

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: << Marcy Sutton >>

@WilcoFiers WilcoFiers requested a review from a team as a code owner December 19, 2018 11:41
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine this time, but it would help to have "Closes #" in the body of your commit so it ends up in the changelog. (I only saw it in the PR description)

@WilcoFiers
Copy link
Contributor Author

@marcysutton that message is in the body of the PR, so it'll be included when I squash I think.

@WilcoFiers WilcoFiers merged commit 88017be into develop Dec 20, 2018
@WilcoFiers WilcoFiers deleted the th-fix branch December 20, 2018 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants