Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typedefs): do not require brand and application #1264

Merged
merged 1 commit into from
Nov 28, 2018
Merged

fix(typedefs): do not require brand and application #1264

merged 1 commit into from
Nov 28, 2018

Conversation

stephenmathieson
Copy link
Member

@stephenmathieson stephenmathieson commented Nov 28, 2018 •
edited by WilcoFiers
Loading

We don't always set both. For example, see axe-webdriverjs.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@stephenmathieson stephenmathieson requested a review from a team as a code owner November 28, 2018 16:07
@stephenmathieson stephenmathieson merged commit 59465dc into develop Nov 28, 2018
@stephenmathieson stephenmathieson deleted the fix-ts-branding branch November 28, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@AdnoC AdnoC Awaiting requested review from AdnoC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenmathieson @WilcoFiers