fix: Avoid IE problems by using nodeName instead of tagName #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing additional usage in |
marcysutton
reviewed
Nov 3, 2018
| @@ -5,7 +5,7 @@ if (ariaHeadingLevel !== null) { | |||
| return true; | |||
| } | |||
|
|
|||
| var headingLevel = node.tagName.match(/H(\d)/); | |||
| var headingLevel = node.nodeName.match(/H(\d)/); | |||
There was a problem hiding this comment.
do you need toUpperCase() here?
There was a problem hiding this comment.
I am going to leave this on as is (no need to uppercase).
There was a problem hiding this comment.
I disagree. In xhtml nodeName is lower case, which means this won't match.
|
@marcysutton - the usage in |
WilcoFiers
approved these changes
Nov 12, 2018
WilcoFiers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a maintenance PR, to update
node.tagNameusages tonode.nodeName.Did not update the usages in:
lib/core/utils/css-parser.js- as this is a copy/pasted (imported) module.lib/core/utils/qsa.js- as this seems to break a lot of tests.Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)