Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow street-address autocomplete on text fields (PR #1217) #1161

Closed
WilcoFiers opened this issue Sep 26, 2018 · 3 comments
Closed

Allow street-address autocomplete on text fields (PR #1217) #1161

WilcoFiers opened this issue Sep 26, 2018 · 3 comments
Assignees
@jeeyyy
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

Even though the HTML 5 spec says street-address is a multiline control and shouldn't be on input[type=text] the spec also has a few examples that show it being used that way. This, plus the fact that street-address seems to be the only thing not allowed on text, suggests we should probably just allow it.
@WilcoFiers WilcoFiers added the fix Bug fixes label Sep 26, 2018
@jeeyyy
Copy link
Contributor

jeeyyy commented Oct 10, 2018

@WilcoFiers

Was this the fix you were thinking? - fc3e898#diff-c8be89ccd7cd8049ef39d04c207728cbR12

@WilcoFiers
Copy link
Contributor Author

That should do, make sure you add tests :)

@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Oct 18, 2018
@jeeyyy jeeyyy mentioned this issue Nov 2, 2018
Merged
4 tasks
@jeeyyy jeeyyy self-assigned this Nov 2, 2018
@jeeyyy jeeyyy changed the title Allow street-address autocomplete on text fields Allow street-address autocomplete on text fields (PR #1217) Nov 2, 2018
@jeeyyy
Copy link
Contributor

jeeyyy commented Nov 6, 2018

PR merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @jeeyyy