Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: 'aria-allowed-attr' fails when using 'aria-errormessage' attribute #1043

Closed
iamrafan opened this issue Aug 3, 2018 · 4 comments
Labels

Comments

@iamrafan
Copy link
Contributor

iamrafan commented Aug 3, 2018

'aria-allowed-attr' should not fail for any of the 3 cases in the below example

axe-core version: 3.0.3
axe-Coconut version: 3.4.0-alpha.2
@WilcoFiers WilcoFiers added support fix Bug fixes labels Aug 5, 2018
@WilcoFiers
Copy link
Contributor

We've overlooked something in #517. In addition to defining aria-errormessage, we should have specified what elements its allowed on. That's a pretty silly oversight, but not too difficult to fix. Your first example would still fail. Because aria-errormessage isn't well supported, we added a check that required that if you use it, there should also be a fallback.

@iamrafan
Copy link
Contributor Author

iamrafan commented Aug 6, 2018

Sure, since aria-errormessage is a global attribute, I think is should be allowed on all the elements when a fallback is provided. Then:

  • it would pass 'aria-allowed-attr' always
  • it would fail 'aria-attr-valid-value' when a fallback is not provided.

@iamrafan
Copy link
Contributor Author

iamrafan commented Aug 7, 2018

@WilcoFiers I mentioned the wrong rule name, this bug is about 'aria-allowed-attr' failures. I made the rule name changes in this thread.

@iamrafan iamrafan changed the title False positive: 'aria-valid-attr' fails when using 'aria-errormessage' attribute False positive: 'aria-allowed-attr' fails when using 'aria-errormessage' attribute Aug 7, 2018
@WilcoFiers
Copy link
Contributor

Jup, I noticed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants