Merge pull request #983 from dequelabs/release-2024-01-09

chore: RC v4.8.3
dequelabs · Jan 9, 2024 · 54b75d0 · 54b75d0
2 parents 854eeb3 + 8cc097d
commit 54b75d0
Show file tree

Hide file tree

Showing 34 changed files with 15,964 additions and 19,463 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -31,6 +31,12 @@ updates:
         versions: ['>=6.0.0']
       - dependency-name: 'node-fetch'
         versions: ['>=3.0.0']
+      - dependency-name: 'delay'
+        versions: ['>=6.0.0']
+      - dependency-name: 'tempy'
+        versions: ['>=2.0.0']
+      - dependency-name: 'chai'
+        versions: ['>=5.0.0']
       # Breaking change due to node version requirements
       - dependency-name: 'commander'
         versions: ['>=10.0.0']

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -59,7 +59,7 @@ jobs:
       - run: npm ci
         # HACK: Force a TTY to enable browser-driver-manager to manipulate stdout.
       - shell: 'script -q -e -c "bash {0}"'
-        run: npx browser-driver-manager install chromedriver --verbose
+        run: npx browser-driver-manager install chromedriver=119 --verbose
         working-directory: packages/cli
       - run: npm run coverage --workspace=packages/cli
 

diff --git a/.github/workflows/update-axe-core.yml b/.github/workflows/update-axe-core.yml
@@ -9,7 +9,7 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    timeout-minutes: 1
+    timeout-minutes: 2
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.8.3](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3) (2024-01-09)
+
+
+### Bug Fixes
+
+* allow cjs version of packages to export a default value ([#943](https://github.com/dequelabs/axe-core-npm/issues/943)) ([b5aee34](https://github.com/dequelabs/axe-core-npm/commit/b5aee3424fe4d0fbc0b2065e9c0bc56ce4032755))
+* Update axe-core to v4.8.3 ([#968](https://github.com/dequelabs/axe-core-npm/issues/968)) ([be9002c](https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b))
+* Update axe-core to v4.8.3 ([#978](https://github.com/dequelabs/axe-core-npm/issues/978)) ([1c83740](https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc))
+* **webdriverio:** fix types between v8 and <v8 ([#962](https://github.com/dequelabs/axe-core-npm/issues/962)) ([0511338](https://github.com/dequelabs/axe-core-npm/commit/0511338017f52fba78c6ff3708f0c9e950e7a34e))
+* **webdriverio:** work with @wdio/globals ([#882](https://github.com/dequelabs/axe-core-npm/issues/882)) ([2e016b4](https://github.com/dequelabs/axe-core-npm/commit/2e016b4e17cff09f158427862f2fd2134a62cbc6))
+* **webdriverjs:** fix default commonJs export ([#927](https://github.com/dequelabs/axe-core-npm/issues/927)) ([b07d38c](https://github.com/dequelabs/axe-core-npm/commit/b07d38cc2d85c6127391686482abf762758dce34))
+
+
+### Reverts
+
+* Revert "fix: Update axe-core to v4.8.3 (#968)" (#977) ([0aff5d8](https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e)), closes [#968](https://github.com/dequelabs/axe-core-npm/issues/968) [#977](https://github.com/dequelabs/axe-core-npm/issues/977)
+* Revert "chore: merge master into develop (#955)" (#956) ([07e7d9e](https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514)), closes [#955](https://github.com/dequelabs/axe-core-npm/issues/955) [#956](https://github.com/dequelabs/axe-core-npm/issues/956)
+
+
+
+
+
 ## [4.8.2](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.2) (2023-11-30)
 
 

diff --git a/lerna.json b/lerna.json
@@ -1,3 +1,3 @@
 {
-  "version": "4.8.2"
+  "version": "4.8.3"
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,11 +23,11 @@
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-react": "^7.31.9",
     "husky": "^8.0.0",
-    "lerna": "^7.3.0",
-    "lint-staged": "^13.0.3",
+    "lerna": "^8.0.1",
+    "lint-staged": "^15.1.0",
     "prettier": "^3.0.3",
     "react": "^17.0.0",
-    "typescript": "^4.8.4"
+    "typescript": "^5.2.2"
   },
   "prettier": {
     "semi": true,

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -3,6 +3,24 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.8.3](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3) (2024-01-09)
+
+
+### Bug Fixes
+
+* Update axe-core to v4.8.3 ([#968](https://github.com/dequelabs/axe-core-npm/issues/968)) ([be9002c](https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b))
+* Update axe-core to v4.8.3 ([#978](https://github.com/dequelabs/axe-core-npm/issues/978)) ([1c83740](https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc))
+
+
+### Reverts
+
+* Revert "fix: Update axe-core to v4.8.3 (#968)" (#977) ([0aff5d8](https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e)), closes [#968](https://github.com/dequelabs/axe-core-npm/issues/968) [#977](https://github.com/dequelabs/axe-core-npm/issues/977)
+* Revert "chore: merge master into develop (#955)" (#956) ([07e7d9e](https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514)), closes [#955](https://github.com/dequelabs/axe-core-npm/issues/955) [#956](https://github.com/dequelabs/axe-core-npm/issues/956)
+
+
+
+
+
 ## [4.8.2](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.2) (2023-11-30)
 
 **Note:** Version bump only for package @axe-core/cli

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@axe-core/cli",
-  "version": "4.8.2",
+  "version": "4.8.3",
   "description": "A CLI for accessibility testing using axe-core",
   "author": {
     "name": "Wilco Fiers",
@@ -47,8 +47,8 @@
     "testing"
   ],
   "dependencies": {
-    "@axe-core/webdriverjs": "^4.8.2",
-    "axe-core": "~4.8.2",
+    "@axe-core/webdriverjs": "^4.8.3",
+    "axe-core": "~4.8.3",
     "chromedriver": "latest",
     "colors": "^1.4.0",
     "commander": "^9.4.1",
@@ -60,13 +60,13 @@
     "@types/mocha": "^10.0.0",
     "@types/selenium-webdriver": "^4.1.5",
     "chai": "^4.3.6",
-    "execa": "5.1.0",
+    "execa": "5.1.1",
     "mocha": "^10.0.0",
     "nyc": "^15.1.0",
     "rimraf": "^5.0.5",
     "tempy": "^1.0.0",
     "ts-node": "^10.9.1",
-    "typescript": "^4.8.4"
+    "typescript": "^5.2.2"
   },
   "nyc": {
     "checkCoverage": true,

diff --git a/packages/playwright/CHANGELOG.md b/packages/playwright/CHANGELOG.md
@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.8.3](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3) (2024-01-09)
+
+
+### Bug Fixes
+
+* allow cjs version of packages to export a default value ([#943](https://github.com/dequelabs/axe-core-npm/issues/943)) ([b5aee34](https://github.com/dequelabs/axe-core-npm/commit/b5aee3424fe4d0fbc0b2065e9c0bc56ce4032755))
+* Update axe-core to v4.8.3 ([#968](https://github.com/dequelabs/axe-core-npm/issues/968)) ([be9002c](https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b))
+* Update axe-core to v4.8.3 ([#978](https://github.com/dequelabs/axe-core-npm/issues/978)) ([1c83740](https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc))
+* **webdriverjs:** fix default commonJs export ([#927](https://github.com/dequelabs/axe-core-npm/issues/927)) ([b07d38c](https://github.com/dequelabs/axe-core-npm/commit/b07d38cc2d85c6127391686482abf762758dce34))
+
+
+### Reverts
+
+* Revert "fix: Update axe-core to v4.8.3 (#968)" (#977) ([0aff5d8](https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e)), closes [#968](https://github.com/dequelabs/axe-core-npm/issues/968) [#977](https://github.com/dequelabs/axe-core-npm/issues/977)
+* Revert "chore: merge master into develop (#955)" (#956) ([07e7d9e](https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514)), closes [#955](https://github.com/dequelabs/axe-core-npm/issues/955) [#956](https://github.com/dequelabs/axe-core-npm/issues/956)
+
+
+
+
+
 ## [4.8.2](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.2) (2023-11-30)
 
 

diff --git a/packages/playwright/package.json b/packages/playwright/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@axe-core/playwright",
-  "version": "4.8.2",
+  "version": "4.8.3",
   "description": "Provides a method to inject and analyze web pages using axe",
   "contributors": [
     {
@@ -51,7 +51,7 @@
     "prepare": "npx playwright install && npm run build"
   },
   "dependencies": {
-    "axe-core": "~4.8.2"
+    "axe-core": "~4.8.3"
   },
   "devDependencies": {
     "@playwright/test": "^1.34.3",
@@ -67,8 +67,8 @@
     "nyc": "^15.1.0",
     "rimraf": "^5.0.5",
     "ts-node": "^10.9.1",
-    "tsup": "^7.2.0",
-    "typescript": "^4.8.4"
+    "tsup": "^8.0.1",
+    "typescript": "^5.2.2"
   },
   "peerDependencies": {
     "playwright-core": ">= 1.0.0"

diff --git a/packages/playwright/test/axe-playwright.spec.ts b/packages/playwright/test/axe-playwright.spec.ts
@@ -472,7 +472,7 @@ describe('@axe-core/playwright', () => {
       const res = await page.goto(`${addr}/context-include-exclude.html`);
       const results = await new AxeBuilder({ page })
         .include('.include')
-        // .exclude('.exclude')
+        .exclude('.exclude')
         .analyze();
       const flattenTarget = flatPassesTargets(results);
 
@@ -513,10 +513,8 @@ describe('@axe-core/playwright', () => {
       const flattenTarget = flatPassesTargets(results);
 
       assert.equal(res?.status(), 200);
-      assert.strictEqual(flattenTarget[0], '.include');
-      assert.strictEqual(flattenTarget[1], '.include2');
-      assert.notInclude(flattenTarget, '.exclude');
-      assert.notInclude(flattenTarget, '.exclude2');
+      assert.isTrue(flattenTarget.includes('.include'));
+      assert.isTrue(flattenTarget.includes('.include2'));
     });
 
     it('with chaining excludes', async () => {

diff --git a/packages/puppeteer/CHANGELOG.md b/packages/puppeteer/CHANGELOG.md
@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.8.3](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3) (2024-01-09)
+
+
+### Bug Fixes
+
+* allow cjs version of packages to export a default value ([#943](https://github.com/dequelabs/axe-core-npm/issues/943)) ([b5aee34](https://github.com/dequelabs/axe-core-npm/commit/b5aee3424fe4d0fbc0b2065e9c0bc56ce4032755))
+* Update axe-core to v4.8.3 ([#968](https://github.com/dequelabs/axe-core-npm/issues/968)) ([be9002c](https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b))
+* Update axe-core to v4.8.3 ([#978](https://github.com/dequelabs/axe-core-npm/issues/978)) ([1c83740](https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc))
+* **webdriverjs:** fix default commonJs export ([#927](https://github.com/dequelabs/axe-core-npm/issues/927)) ([b07d38c](https://github.com/dequelabs/axe-core-npm/commit/b07d38cc2d85c6127391686482abf762758dce34))
+
+
+### Reverts
+
+* Revert "fix: Update axe-core to v4.8.3 (#968)" (#977) ([0aff5d8](https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e)), closes [#968](https://github.com/dequelabs/axe-core-npm/issues/968) [#977](https://github.com/dequelabs/axe-core-npm/issues/977)
+* Revert "chore: merge master into develop (#955)" (#956) ([07e7d9e](https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514)), closes [#955](https://github.com/dequelabs/axe-core-npm/issues/955) [#956](https://github.com/dequelabs/axe-core-npm/issues/956)
+
+
+
+
+
 ## [4.8.2](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.2) (2023-11-30)
 
 

diff --git a/packages/puppeteer/package.json b/packages/puppeteer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@axe-core/puppeteer",
-  "version": "4.8.2",
+  "version": "4.8.3",
   "description": "Provides a chainable axe API for Puppeteer and automatically injects into all frames",
   "repository": {
     "type": "git",
@@ -39,7 +39,7 @@
     "@types/express": "^4.17.14",
     "@types/mocha": "^10.0.0",
     "@types/node": "^20.8.10",
-    "@types/sinon": "^10.0.13",
+    "@types/sinon": "^17.0.0",
     "async-listen": "^3.0.1",
     "axe-test-fixtures": "github:dequelabs/axe-test-fixtures#v1",
     "chai": "^4.3.6",
@@ -48,14 +48,14 @@
     "mocha": "^10.0.0",
     "nyc": "^15.1.0",
     "puppeteer": "19.7.3",
-    "sinon": "^14.0.1",
+    "sinon": "^17.0.1",
     "source-map-support": "^0.5.21",
     "ts-node": "^10.9.1",
-    "tsup": "^7.2.0",
-    "typescript": "^4.8.4"
+    "tsup": "^8.0.1",
+    "typescript": "^5.2.2"
   },
   "dependencies": {
-    "axe-core": "~4.8.2"
+    "axe-core": "~4.8.3"
   },
   "peerDependencies": {
     "puppeteer": ">=1.10.0"

diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
@@ -3,6 +3,26 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [4.8.3](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.3) (2024-01-09)
+
+
+### Bug Fixes
+
+* allow cjs version of packages to export a default value ([#943](https://github.com/dequelabs/axe-core-npm/issues/943)) ([b5aee34](https://github.com/dequelabs/axe-core-npm/commit/b5aee3424fe4d0fbc0b2065e9c0bc56ce4032755))
+* Update axe-core to v4.8.3 ([#968](https://github.com/dequelabs/axe-core-npm/issues/968)) ([be9002c](https://github.com/dequelabs/axe-core-npm/commit/be9002c518b335f56fa21e1bff99e07281be814b))
+* Update axe-core to v4.8.3 ([#978](https://github.com/dequelabs/axe-core-npm/issues/978)) ([1c83740](https://github.com/dequelabs/axe-core-npm/commit/1c837404aa2a63fb6be6f04760d1faec886bc5dc))
+* **webdriverjs:** fix default commonJs export ([#927](https://github.com/dequelabs/axe-core-npm/issues/927)) ([b07d38c](https://github.com/dequelabs/axe-core-npm/commit/b07d38cc2d85c6127391686482abf762758dce34))
+
+
+### Reverts
+
+* Revert "fix: Update axe-core to v4.8.3 (#968)" (#977) ([0aff5d8](https://github.com/dequelabs/axe-core-npm/commit/0aff5d86e539cb9054bc3bd62a2f2cba8a716b3e)), closes [#968](https://github.com/dequelabs/axe-core-npm/issues/968) [#977](https://github.com/dequelabs/axe-core-npm/issues/977)
+* Revert "chore: merge master into develop (#955)" (#956) ([07e7d9e](https://github.com/dequelabs/axe-core-npm/commit/07e7d9e7e166391e4fe406db5dc541f56ca44514)), closes [#955](https://github.com/dequelabs/axe-core-npm/issues/955) [#956](https://github.com/dequelabs/axe-core-npm/issues/956)
+
+
+
+
+
 ## [4.8.2](https://github.com/dequelabs/axe-core-npm/compare/v4.8.1...v4.8.2) (2023-11-30)
 
 

diff --git a/packages/react/jest.config.js b/packages/react/jest.config.js
@@ -0,0 +1,9 @@
+module.exports = {
+  testEnvironment: 'jsdom',
+  setupFilesAfterEnv: ['<rootDir>/test/jest.setup.js'],
+  moduleNameMapper: {
+    // Note: the '../../' is required as we're targeting the root `node_modules`
+    // @see https://github.com/sinonjs/sinon/issues/2522
+    sinon: '<rootDir>/../../node_modules/sinon/pkg/sinon.js'
+  }
+};
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@axe-core/react",
-  "version": "4.8.2",
+  "version": "4.8.3",
   "description": "Dynamic accessibility analysis for React using axe-core",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",
@@ -60,7 +60,7 @@
   "author": "Dylan Barrell ([email protected])",
   "license": "MPL-2.0",
   "dependencies": {
-    "axe-core": "~4.8.2",
+    "axe-core": "~4.8.3",
     "requestidlecallback": "^0.3.0"
   },
   "devDependencies": {
@@ -71,7 +71,7 @@
     "@types/react": "17.0.0",
     "@types/react-dom": "17.0.0",
     "@types/requestidlecallback": "^0.3.5",
-    "@wojtekmaj/enzyme-adapter-react-17": "^0.6.7",
+    "@wojtekmaj/enzyme-adapter-react-17": "^0.8.0",
     "chai": "^4.3.6",
     "enzyme": "^3.11.0",
     "http-server": "^14.1.1",
@@ -80,19 +80,13 @@
     "react": "17.0.0",
     "react-dom": "17.0.0",
     "react-shadow": "^20.4.0",
-    "sinon": "^14.0.1",
+    "sinon": "^17.0.1",
     "ts-node": "^10.9.1",
-    "tsup": "^7.2.0",
-    "typescript": "^4.8.4"
+    "tsup": "^8.0.1",
+    "typescript": "^5.2.2"
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/dequelabs/axe-core-npm.git"
-  },
-  "jest": {
-    "testEnvironment": "jsdom",
-    "setupFilesAfterEnv": [
-      "<rootDir>/test/jest.setup.js"
-    ]
   }
 }
diff --git a/packages/react/test/tsconfig.json b/packages/react/test/tsconfig.json
diff --git a/packages/react/tsconfig.json b/packages/react/tsconfig.json
@@ -10,7 +10,8 @@
     "target": "esnext",
     "lib": ["dom", "esnext"],
     "resolveJsonModule": true,
-    "esModuleInterop": true
+    "esModuleInterop": true,
+    "skipLibCheck": true
   },
   "exclude": ["test", "dist", "node_modules", "tsup.config.ts"]
 }