This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
fix: Fix false positive by ignoring text that lives over an image overlay #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #59
Note: This adds a threshold value of 100,000, which is somewhat arbitrary based on the images in the unit tests. The largest value reached in the current unit tests is 61.425. There's a possibility of a non-overlay text reaching this threshold--if that occurs, then that scanline will be ignored and scanning will continue with other scanlines. It's a heuristic, but intended to err on the side of fewer false positives.
Requester Review Items
Dev Team Review Items
To be filled out by @dequelabs/mobile.
Code Owner Review Items
To be filled out by @dequelabs/mobileadmin.
Merger Review Items