still allow package analysis to continue even if metadata isn't valid #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-analyze-empty-version-range
branch
from
da81966
to
2449b4b
Compare
sebasgomez238
approved these changes
Nov 18, 2024
JamieMagee
reviewed
Nov 18, 2024
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/NuGetContext.cs
Show resolved
Hide resolved
JamieMagee
approved these changes
Nov 18, 2024
brettfo
force-pushed
the
dev/brettfo/nuget-analyze-empty-version-range
branch
from
2449b4b
to
4bbdfa3
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-analyze-empty-version-range
branch
from
4bbdfa3
to
14c83de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during a manual audit of the logs for the
nuget_native_analysisexperiment.When querying the NuGet package source for metadata, the resultant JSON can contain an empty string for a version
rangeproperty which makes deserialization fail. The package update can still continue, we just can't return a reasonable repo URL.