Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replacement of plus with dot in python latest version #10838

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Oct 23, 2024

What are you trying to accomplish?

Fix issue 10813 where a local python version like 20241015.20437.714166+master.fe8974a is getting the plus sign replaced with a dot and, as a result, failing validation. With the updated version regex, the plus gets parsed correctly therefore this hack is no longer necessary.

How will you know you've accomplished your goal?

The added test will pass.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Oct 23, 2024
@amazimbe amazimbe marked this pull request as ready for review October 23, 2024 22:31
@amazimbe amazimbe requested a review from a team as a code owner October 23, 2024 22:31
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

@amazimbe amazimbe force-pushed the amazimbe/do-not-substitute+in-version branch from e6f247c to 9b9db27 Compare October 24, 2024 09:17
@amazimbe amazimbe merged commit 6bfc298 into main Oct 24, 2024
58 checks passed
@amazimbe amazimbe deleted the amazimbe/do-not-substitute+in-version branch October 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python illformed_requirement
3 participants