Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit for BitBucket PR description length #7678

Closed
1 task done
jeffwidman opened this issue Jul 31, 2023 · 4 comments · Fixed by #7693
Closed
1 task done

Add limit for BitBucket PR description length #7678

jeffwidman opened this issue Jul 31, 2023 · 4 comments · Fixed by #7693
Labels
F: pull-requests Issues about Dependabot pull requests T: feature-request Requests for new features V: Bitbucket Issues relating to Bitbucket support

Comments

@jeffwidman
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Feature description

We recently landed a PR that makes it easy to configure the length of the PR description:

However, that still needs to be updated with a limit for BitBucket:
https://github.com/dwc0011/dependabot-core/blob/ef7e8728ae9a7013815ced67402c96e8a75c88d0/common/lib/dependabot/pull_request_creator.rb#L225-L233

Creating this issue in case anyone in the open source community wants to take a stab at it.

@jeffwidman jeffwidman added T: feature-request Requests for new features V: Bitbucket Issues relating to Bitbucket support F: pull-requests Issues about Dependabot pull requests labels Jul 31, 2023
@jeffwidman
Copy link
Member Author

@stefangr any interest in tackling this?

Keep in mind the limit that Google/BitBucket docs show may be incorrect per this comment:

@stefangr
Copy link
Contributor

stefangr commented Aug 1, 2023

Sure.

I can try to find the limit.

@stefangr
Copy link
Contributor

stefangr commented Aug 1, 2023

@jeffwidman
I went up to a PR description with 1,310,720 characters, which was accepted by bitbucket (cloud) without any problem.

The UX on the PR page is bad with such a large PR description, so I suggest to limit it to something like 262,144 (4 x 65,536)

@jeffwidman
Copy link
Member Author

Want to submit that as a PR?

Truncating shorter than the "real" limit makes sense to me... perhaps include a clarifying code comment?

# BitBucket Cloud accepts > 1MB characters, but they display poorly in the UI, so limiting to 4x 65,536
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: pull-requests Issues about Dependabot pull requests T: feature-request Requests for new features V: Bitbucket Issues relating to Bitbucket support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants