-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot fails to parse a more complex poetry dependency #5363
Comments
Hei @mvadari, thanks for the report! This is a weird one because while Poetry supports this format, standard Python does not. I should've probably got back to you earlier when I first looked at this, to at least mention the easy workaround to you: change the requirements to be separated by commas instead of spaces. Anyways, if Poetry supports this, we probably should too, so I opened a PR to fix it! See #5735. |
Thanks! I'm unfamiliar with how new features are added, will dependabot just automatically be resolved at some future point or will I need to change something in the config to update? |
No problem! I don't think you need to change anything, it should work next time Dependabot tries to update your repo after the fix is deployed! |
Confirming that it is indeed working, thanks! 💯 |
Great! Thanks for circling back to let us know. |
Package ecosystem
pip
Package manager version
poetry
Language version
Python 3.7-3.10
Manifest location and content before the Dependabot update
https://github.com/XRPLF/xrpl-py/blob/master/pyproject.toml
dependabot.yml content
What you expected to see, versus what you actually saw
Dependabot hasn't been running at all on this repo, but it has on a repo with an identical dependabot.yml file. I went to Insights -> Dependency graph -> Dependabot and found this
Illformed requirement
error:I'm pretty sure it's coming from this part of the
pyproject.toml
file:This is completely valid in poetry, but Dependabot is struggling.
🕹 Bonus points: Smallest manifest that reproduces the issue
See above.
The text was updated successfully, but these errors were encountered: