-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce hardcoding of amd64
to make the dev experience more pleasant on M1 Macs
#4810
Comments
mmm just a warning? I couldn't get it to build at all on my machine, any hints? |
Related #4697 |
@deivid-rodriguez I can't get the But I could pull the latest pre-built docker image following these instructions: And then it seems to run fine, other than the warning mentioned in my first post. So as long as you're not needing to modify the source |
Ah, alright, I'll try that then 👍. |
Closing as this was partially addressed by #4858 and this ticket is so broad that it's not super actionable... with the popularity of the M1 laptops, I'm sure we'll soon flush out any additional bugs and tackle them one-by-one. |
Running
bin/dev-docker-shell
on my M1 Mac throws this warning:Grep'ing the repo I see a bunch of
amd64
hardcoding: https://github.com/dependabot/dependabot-core/search?q=amd64Ideally the architecture would depend on the host platform... that's likely not feasible everywhere, but perhaps some of these could be switched to dynamically picking the architecture. That way if someone is debugging a single ecosystem, possibly it could run natively on arm / apple silicon.
That'd result in a more pleasant dev experience, especially as more and more devs switch to the M1 / M2 apple laptops.
The text was updated successfully, but these errors were encountered: