Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade cargo package when latest version is yanked #2155

Open
alex opened this issue May 17, 2019 · 2 comments
Open

Downgrade cargo package when latest version is yanked #2155

alex opened this issue May 17, 2019 · 2 comments
Labels
F: dependency-downgrades Avoiding unintentional downgrades, or forcing downgrades when really needed F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. L: rust:cargo Rust crates via cargo T: feature-request Requests for new features

Comments

@alex
Copy link

alex commented May 17, 2019

In a Rust project, I merged a PR from dependabot to upgrade bitflags to 1.0.5. Later, the 1.0.5 release was yanked. I think in this case it'd be appropriate for dependabot to lower the version to 1.0.4, the otherwise latest version. I think this behavior makes sense because if I run cargo update locally, I get a downgrade. You can see this with the following repository: https://github.com/alex/csv-sql

@greysteil
Copy link
Contributor

I'd really love to do this, but it's hard! Dependabot has a bunch of logic that prevents it from accidentally creating downgrade PRs, and that gets in the way here. I'm going to leave this open because this is definitely possible (especially given how the crates.io index works), but I can't look at it straight away.

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@infin8x infin8x added F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. L: rust:cargo Rust crates via cargo T: feature-request Requests for new features labels Jul 2, 2020
@dependabot dependabot deleted a comment from stale bot Aug 23, 2022
@deivid-rodriguez deivid-rodriguez added the F: dependency-downgrades Avoiding unintentional downgrades, or forcing downgrades when really needed label Aug 31, 2022
@snarfed
Copy link

snarfed commented Mar 9, 2023

Yes! Beyond Rust, this would be useful for all package ecosystems that support yanking. Eg I recently got bit by a hang bug in grpc's pip package, grpc/grpc#31885. They eventually yanked the affected release version, 1.52.0, but dependabot had already upgraded my projects, so I had to debug myself and eventually figure out the affected dependency and what to do about it, grpc/grpc#31885 (comment). Would definitely have been nice if dependabot spared me that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: dependency-downgrades Avoiding unintentional downgrades, or forcing downgrades when really needed F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. L: rust:cargo Rust crates via cargo T: feature-request Requests for new features
Projects
None yet
Development

No branches or pull requests

5 participants