Fix Rails 7.2 Deprecation warnings

[ryan-mcneil]

Summary

• Fix Deprecation warnings blocking Rails 7.2+ upgrade

Notes

• DEPRECATION WARNING: config.active_support.remove_deprecated_time_with_zone_name is deprecated and will be removed in Rails 7.2.
  • Fixed by removing the deprecated config option config.active_support.remove_deprecated_time_with_zone_name. We had it set to false, suggesting we used the old standard, the more "human readable" format instead of the new standard. For example American/New_York vs the old Eastern Time (US & Canada). As this didn't break any specs, I think it's ok.
• DEPRECATION WARNING: Your secret_key_baseis configured inRails.application.secrets, which is deprecated in favor of Rails.application.credentials and will be removed in Rails 7.2.
  • We don't use secrets.yml (or the newer credentials.yml.enc for that matter).
  • No issues removing secrets.yml, as there are no references to Rails.application.secrets

Related issue(s)

• [VETS-API] Fix Deprecation Warnings ahead of Rails 7.2 va.gov-team#98145

Testing done

• Specs Passing and local server booting after making changes

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/config_helper.rb

[github-actions]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: lib/config_helper.rb

[github-actions]

Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: config/secrets.yml