Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVI integration #244

Closed
ayaleloehr opened this issue Oct 11, 2016 · 7 comments
Closed

MVI integration #244

ayaleloehr opened this issue Oct 11, 2016 · 7 comments

Comments

@ayaleloehr
Copy link
Contributor

Using mock MVI service. Connect with @kreek on how to make this work.

@saneshark
Copy link
Contributor

Blocked by:

  1. mock MVI service is only supported on dev
  2. dev cannot handshake with MHV services

Unless dev firewall restrictions allow to communicate with MHV again or we can use the MockService on staging, we can't really test this one.

@ayaleloehr
Copy link
Contributor Author

ayaleloehr commented Oct 14, 2016

Dev firewall restrictions are not going to be opened unfortunately.

With that, the mock MVI service will be going on staging until we get real connectivity there (hopefully next week). @omgitsbillryan and/or @kreek are working on getting the mock MVI service onto staging.

This issue is also being tracked in https://github.com/department-of-veterans-affairs/platform-team/issues/140

@ayaleloehr
Copy link
Contributor Author

@saneshark Implemented for Rx here, then reverted in this.

Still need to have it implemented for SM, although cannot merge that until step 4 is completed here. Thinking maybe @mphprogrammer should do the SM implementation so he has visibility into this codebase and to limit @saneshark 's bus factor.

@aub
Copy link
Contributor

aub commented Oct 28, 2016

@ayaleloehr I was planning on implementing that for SM once my PR here gets merged in. It should be a really simple duplication of the work @saneshark has already done for Rx.

@ayaleloehr
Copy link
Contributor Author

@aub touch base quickly with @mphprogrammer first please. Should be fine but he might have started that so just want to be sure we don't duplicate the duplication

@robbiethegeek
Copy link
Contributor

@ayaleloehr on the login is reenabled on RX we should be able to close.

@ayaleloehr
Copy link
Contributor Author

#417 got the 👍 so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants