Feature/APPEALS-44512-Zeitwerk-auto-transition #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
sbashamoni
approved these changes
Nov 7, 2024
sbashamoni
added a commit
that referenced
this pull request
Nov 14, 2024
* Update Caseflow-Commons for Zeitwerk
* Remove classic loading, added Zeitwerk loading options
* Added to_prepare's - Solves DW on autoloading initialized constants
* Added Zeitwerk initializer file
* Refactored bgs_errors.rb and bgs.rb
* Remove require statements
* Added Fakes and TestAuthStrategy modules
* Readded accidental require deletion
* Removed plural from CurrentUserLoadTests
* Refactored for One File One Constant
* Added Zeitwerk Rspec test
* Fix Rubocop setup - removed incorrect include setup
* Added custom Rubocop - Top Level Constatns Per File
* Rename and moved Zeitwerk spec for Caseflow parity
* Fixed custom cop spec file structure
* Zeitwerk spec comments addressed
* Refactored for Caseflow parity
* Renamed for consistency
* Safety require
* Safety require and to_prepare for BGS
* Added autoload/eagerload section
* Renamed for consistency
* Readded require so to_prepare could be removed
* Added rubocop_todo for temp ignore linter errors
* Required changes for .rubocop.yml to work
* Updated Rubocop todo with proper generation
* Unecessary ShellCommand removed
* Ignored TestAuthStrategy in autoloading - unneeded
* Update .rubocop.yml
* Update app/services/external_api/vbms_service.rb
* Add #{root} to config/application.rb
* Cosmetic Update config/initializers/shoryuken.rb
* Cosmetic Update config/initializers/shoryuken.rb
* Cosmetic Update config/initializers/shoryuken.rb
* Cosmetic Update lib/fakes/test_auth_strategy.rb
* Added after_initialize to prevent multiple subscribers on relead
* Added before_initialize so Error class is loaded before anything else
* ✏️ Fix typo in filename
* 🚚 Move spec file to proper location
* ♻️ Lexically order filters in .simplecov
* 🔧 Filter `lib/efolder/migration.rb` from simplecov coverage
* ⬆️ Update `caseflow-commons` dependecy
---------
Co-authored-by: AKeyframe <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
sbashamoni
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeitwerk auto transitions PR to release branch