Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/APPEALS-43728-react-18-upgrade-release #1729

Merged

Conversation

sbashamoni
Copy link
Contributor

@sbashamoni sbashamoni commented Oct 25, 2024

Resolves APPEALS-44522

Description

The following details the changes made to upgrade eFolder to React 18.2.0. The changes made involve necessary syntax updates, complaint versioning, and addressing breaking changes, all of which are made to resolve warnings received during the upgrade process.

React and React-DOM Versions:

  • Old: React and React-DOM were at version ^16.2.0.
  • Updated: React and React-DOM are now at version 18.2.0.

React-Router-DOM Version:

  • Old: React-Router-DOM was at version ^4.2.2.
  • Updated: React-Router-DOM is now at version 5.3.4.

*Note - React Router is necessary to upgrade to be compliant with the React 18 which deprecates childContextTypes API which is no longer supported and will be removed in the next major release.
The upgrade is made to v5 to be consistent with Caseflow Frontend Toolkit.

Caseflow Frontend Toolkit:

  • Old: It was added with commit hash a05abe6.
  • Updated: The toolkit is now specified from the "upgrade-test" branch of the repository.

*Note - the above upgrade to the Caseflow Frontend toolkit is a test branch that points to upgrades necessary for the toolkits compliance with both Caseflow and eFolder. The toolkit itself also requires updates to React 18.2.0. As far as eFolder is concerned the update only includes a change for the Redux Base component which wraps the root and passes the redux store. Caseflow Frontend toolkit upgrade branch

Refactoring of index.jsx

  • React 18 introduces createRoot as the recommended way to create a root for rendering in concurrent mode. By updating to use createRoot, the codebase ensures compatibility with React 18 and takes advantage of its new features and optimizations.

AdamShawBAH and others added 3 commits October 23, 2024 13:14
* inital commit

* updated react-redux to match frontend toolkit

* lint fix

* remove comments

* modified: package.json with new Caseflow-frontend-toolkit branch

* update toolkit hash

---------

Co-authored-by: hawkespoulterva <[email protected]>
@sbashamoni sbashamoni merged commit 31513b8 into release/FY25Q1.2.0 Oct 25, 2024
4 of 6 checks passed
sbashamoni added a commit that referenced this pull request Oct 30, 2024
* Shaw/APPEALS-44523 react upgrade 10 23 (#1726)

* inital commit

* updated react-redux to match frontend toolkit

* lint fix

* remove comments

* modified: package.json with new Caseflow-frontend-toolkit branch

* update toolkit hash

---------



* cashflow-frontend-toolkit commit hash updated

* updated yarn.lock

---------

Co-authored-by: AdamShawBAH <[email protected]>
Co-authored-by: hawkespoulterva <[email protected]>
sbashamoni added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants