Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript (3.5.1) #597

Closed
wants to merge 1 commit into from
Closed

Add TypeScript (3.5.1) #597

wants to merge 1 commit into from

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Sep 16, 2019

Refs #428

This is an MVP for supporting TypeScript as part of the std library.

It is a copy of the typescript/lib in typescript/vendor with and addition to the ./vendor/typescript.js so that it properly exposes itself globally when loaded in Deno. It also requires denoland/deno@c30deca or later to work properly.

@brandonros
Copy link

Any idea why CI/CD would be failing?

@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 20, 2019

Any idea why CI/CD would be failing?

Yeah, as mentioned, it needs a new version of Deno to be updated in CI, then I need to rebase the PR.

@hayd
Copy link
Contributor

hayd commented Sep 20, 2019

Can this be a git submodule? Then when deno_std is migrated to deno it could be a symlink.

@zekth
Copy link
Contributor

zekth commented Sep 20, 2019

Can this be a git submodule? Then when deno_std is migrated to deno it could be a symlink.

As the move is coming in a short amount of time, this patch is not really usefull i think.

@kitsonk
Copy link
Contributor Author

kitsonk commented Sep 20, 2019

As the move is coming in a short amount of time, this patch is not really usefull i think.

As it stands no. It was more to show how we would solve #428. @ry asked me specifically to look at it. I got it working, but I was leaving Ry to comment on it to any degree he felt he wanted to.

inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
This also makes the `imageUrl` property required in the `MetaProps`
interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants