Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that the librusty_v8.a downloaded/used matches the one that is expected #804

Closed
lucacasonato opened this issue Oct 11, 2021 · 3 comments
Closed

Assert that the librusty_v8.a downloaded/used matches the one that is expected #804

lucacasonato opened this issue Oct 11, 2021 · 3 comments

Comments

@lucacasonato
Copy link
Member

lucacasonato commented Oct 11, 2021 •
edited
Loading

Due to caching it is possible and relatively easy to accidentally build rusty_v8 with the wrong (old) librusty_v8.a.
@bnoordhuis
Copy link
Contributor

A duplicate, sort of, of #545 - checksumming the .a would fix that.

@espindola
Copy link
Contributor

Fixed by 26d60b7? We don't verify it, but short of the released file changing or the local one being corrupted it should work now.

@lucacasonato
Copy link
Member Author

Yup, that should fix this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@espindola @bnoordhuis @lucacasonato