feat: restore resolving config from multiple paths and combine config discovery #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Jul 3, 2024
Comment on lines
+402
to
+404
| log::warn!( | ||
| "Wildcards in npm workspaces are not yet supported. Ignoring." | ||
| ); |
There was a problem hiding this comment.
Not a big deal, but without emoji/color this might be easy to miss.
There was a problem hiding this comment.
Let's just leave this as-is for now because hopefully we can implement this before the next minor release. I opened #67
bartlomieju
reviewed
Jul 3, 2024
bartlomieju
reviewed
Jul 3, 2024
bartlomieju
approved these changes
Jul 3, 2024
…on in a workspace member
dsherret
added a commit
to denoland/deno
that referenced
this pull request
Jul 4, 2024
Adds much better support for the unstable Deno workspaces as well as support for npm workspaces. npm workspaces is still lacking in that we only install packages into the root node_modules folder. We'll make it smarter over time in order for it to figure out when to add node_modules folders within packages. This includes a breaking change in config file resolution where we stop searching for config files on the first found package.json unless it's in a workspace. For the previous behaviour, the root deno.json needs to be updated to be a workspace by adding `"workspace": ["./path-to-pkg-json-folder-goes-here"]`. See details in denoland/deno_config#66 Closes #24340 Closes #24159 Closes #24161 Closes #22020 Closes #18546 Closes #16106 Closes #24160
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Adds much better support for the unstable Deno workspaces as well as support for npm workspaces. npm workspaces is still lacking in that we only install packages into the root node_modules folder. We'll make it smarter over time in order for it to figure out when to add node_modules folders within packages. This includes a breaking change in config file resolution where we stop searching for config files on the first found package.json unless it's in a workspace. For the previous behaviour, the root deno.json needs to be updated to be a workspace by adding `"workspace": ["./path-to-pkg-json-folder-goes-here"]`. See details in denoland/deno_config#66 Closes denoland#24340 Closes denoland#24159 Closes denoland#24161 Closes denoland#22020 Closes denoland#18546 Closes denoland#16106 Closes denoland#24160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better config discovery that isn't as confusing and cause issues like this.
Essentially now that we have workspaces, we can use the exact same rules for discovering deno.json files that we do for package.json files:
/home/david/project/node_modules/package/file.js, then it should start discovery at/home/david/project/. That way we don't cause errors about configs not being in a workspace for stuff in the node_modules folder and so we properly discover the project configs (and not stop at the first found package.json)This is a breaking change for some projects, but it's easy to work around by adding the config as part of the workspace and it will be better in the long term.