Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): script arguments come after '--' #3621

Merged
merged 14 commits into from
Jan 8, 2020
Prev Previous commit
Next Next commit
fix installer
ry committed Jan 8, 2020
commit 6e03495e585f1d1423f993623920debd8489672d
1 change: 1 addition & 0 deletions std/installer/mod.ts
Original file line number Diff line number Diff line change
@@ -255,6 +255,7 @@ export async function install(
"run",
...grantedPermissions.map(getFlagFromPermission),
moduleUrl,
"--",
...scriptArgs
];

2 changes: 0 additions & 2 deletions std/installer/test.ts
Original file line number Diff line number Diff line change
@@ -386,9 +386,7 @@ installerTest(async function installAndMakesureArgsRight(): Promise<void> {

try {
const b = await readAll(ps.stdout);

const s = new TextDecoder("utf-8").decode(b);

const obj = JSON.parse(s);

assertEquals(obj[0], "arg1");