feat(unstable): add metrics to otel #27143
Open
+1,172
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Luca Casonato <[email protected]>
devsnek
requested review from
bartlomieju
and removed request for
lucacasonato
bartlomieju
reviewed
Nov 29, 2024
|
|
||
| impl MetricProcessor { | ||
| fn new(exporter: MetricExporter) -> Self { | ||
| let (tx, mut rx) = tokio::sync::mpsc::channel(2048); |
There was a problem hiding this comment.
Is there any reasoning why buffer of this size was chosen?
| fn force_flush(&self) -> Result<(), anyhow::Error> { | ||
| let (tx, rx) = tokio::sync::oneshot::channel(); | ||
| self.tx.try_send(MetricProcessorMessage::Flush(tx))?; | ||
| deno_core::futures::executor::block_on(rx)?; |
There was a problem hiding this comment.
Using block_on is usually trouble, but I don't see any other way here...
Comment on lines
+789
to
+795
| let x = v8::ValueView::new(scope, string); | ||
| match x.data() { | ||
| v8::ValueViewData::OneByte(bytes) => { | ||
| String::from_utf8_lossy(bytes).into_owned() | ||
| } | ||
| v8::ValueViewData::TwoByte(bytes) => String::from_utf16_lossy(bytes), | ||
| } |
There was a problem hiding this comment.
Is there a reason to do it instead of v8::String::to_rust_string_lossy()?
| spans.on_end(temporary_span.0); | ||
| } | ||
|
|
||
| pub struct TemporaryMetricsExport { |
There was a problem hiding this comment.
Could you add some docstrings here about the purpose of these structs and enums?
Comment on lines
+1361
to
+1363
| histogram | ||
| .data_points | ||
| .last_mut() |
There was a problem hiding this comment.
Is it guaranteed there's gonna be at least one element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #26852
Initial support for exporting metrics.